From 50bd551cb6d6357f26f1cdcad36e65b90ac79b0c Mon Sep 17 00:00:00 2001 From: Richard Barnes Date: Wed, 20 Mar 2024 12:31:48 -0700 Subject: [PATCH] Remove unused variables in fboss/agent/state/Interface.cpp Summary: LLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance. This diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code. - If you approve of this diff, please use the "Accept & Ship" button :-) Reviewed By: peygar Differential Revision: D55099975 fbshipit-source-id: c4c4d45c215f0bf401a9795121fd75bca9bad6d2 --- fbpcf/frontend/test/benchmarks/FrontendBenchmark.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fbpcf/frontend/test/benchmarks/FrontendBenchmark.cpp b/fbpcf/frontend/test/benchmarks/FrontendBenchmark.cpp index 44d43c09..6d551d5a 100644 --- a/fbpcf/frontend/test/benchmarks/FrontendBenchmark.cpp +++ b/fbpcf/frontend/test/benchmarks/FrontendBenchmark.cpp @@ -19,7 +19,7 @@ namespace fbpcf::frontend { -const bool unsafe = true; +// const bool unsafe = true; const uint32_t batchSize = 1000; template