From 3e809b2259d01ae8943762d953e2d3c1038ee514 Mon Sep 17 00:00:00 2001 From: Richard Barnes Date: Sun, 18 Feb 2024 10:36:15 -0800 Subject: [PATCH] Remove unused variables in fbpcf/mpc_std_lib/unified_data_process/serialization/RowStructureDefinition.h (#531) Summary: Pull Request resolved: https://github.com/facebookresearch/fbpcf/pull/531 LLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance. This diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code. - If you approve of this diff, please use the "Accept & Ship" button :-) Reviewed By: palmje Differential Revision: D53779568 fbshipit-source-id: 5e551ab8b86f1b1fd3027f1d3b123b11a6a1a46b --- .../unified_data_process/serialization/RowStructureDefinition.h | 1 - 1 file changed, 1 deletion(-) diff --git a/fbpcf/mpc_std_lib/unified_data_process/serialization/RowStructureDefinition.h b/fbpcf/mpc_std_lib/unified_data_process/serialization/RowStructureDefinition.h index 68f04f91..99855513 100644 --- a/fbpcf/mpc_std_lib/unified_data_process/serialization/RowStructureDefinition.h +++ b/fbpcf/mpc_std_lib/unified_data_process/serialization/RowStructureDefinition.h @@ -158,7 +158,6 @@ class RowStructureDefinition : public IRowStructureDefinition { columnDefinition : *columnDefinitions_.get()) { const IColumnDefinition* columnPointer = columnDefinition.get(); - auto columnType = columnDefinition->getColumnType(); if (columnDefinition->getColumnType() == IColumnDefinition<