Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Blockquote's withText method #231

Open
JuhG opened this issue Jun 30, 2017 · 0 comments
Open

Blockquote's withText method #231

JuhG opened this issue Jun 30, 2017 · 0 comments
Labels

Comments

@JuhG
Copy link

JuhG commented Jun 30, 2017

The withText method in the Blockquote class doesn't do anything currently. The content saved to the text property is not used anywhere and the isValid method returns always false. This is because they are using the parent TextContainer's methods.

One way of solving this would be to make withText a simple wrapper around appendText, the other is to make a custom isValid method and modify the toDOMElement method to use the text property.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants