Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lexical-table] Bug Fix: Fix scrollable table exportDOM #6884

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

etrepum
Copy link
Collaborator

@etrepum etrepum commented Nov 29, 2024

Description

Fix TableNode.exportDOM regression when using scrollable tables

Closes #6882

Test plan

I don't have time to do unit tests right now but this fixes it, if you wanted to release ASAP.

Before

Insert relevant screenshots/recordings/automated-tests

After

Insert relevant screenshots/recordings/automated-tests

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 29, 2024
Copy link

vercel bot commented Nov 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 3:45am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 3:45am

Copy link

size-limit report 📦

Path Size
lexical - cjs 30.92 KB (0%)
lexical - esm 30.83 KB (0%)
@lexical/rich-text - cjs 39.73 KB (0%)
@lexical/rich-text - esm 32.65 KB (0%)
@lexical/plain-text - cjs 38.32 KB (0%)
@lexical/plain-text - esm 29.93 KB (0%)
@lexical/react - cjs 41.46 KB (0%)
@lexical/react - esm 34 KB (0%)

@ivailop7 ivailop7 added this pull request to the merge queue Nov 29, 2024
Merged via the queue into facebook:main with commit 9a51939 Nov 29, 2024
39 of 41 checks passed
@etrepum
Copy link
Collaborator Author

etrepum commented Nov 29, 2024

The reason for this regression is because the exportDOM machinery ($appendNodesToHTML) doesn't currently have any support for getDOMSlot so the children ended up in the scrollable div instead of the table node since the result of createDOM was used directly as the element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrollable tables do not copy content
4 participants