Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different result for ktfmtFormat on Windows vs. OSX #516

Open
hamen opened this issue Sep 18, 2024 · 2 comments
Open

Different result for ktfmtFormat on Windows vs. OSX #516

hamen opened this issue Sep 18, 2024 · 2 comments

Comments

@hamen
Copy link

hamen commented Sep 18, 2024

Hi all 😀

We are using ktfmtFormat in Jewel (https://github.com/JetBrains/jewel) and we are seeing different behaviors on Windows and OSX.

Running ktfmtFormat on this commit https://github.com/JetBrains/jewel/actions/runs/10919605303/job/30307618757 on Windows will produce no changes to any files, and then when the CI runs check will error out with:

Execution failed for task ':ide-laf-bridge:ktfmtCheckMain'.
> [ktfmt] Found 1 files that are not properly formatted:
  src/main/kotlin/org/jetbrains/jewel/bridge/theme/IntUiBridge.kt

Running ktfmtFormat on Mac will change a couple of files, as shown in this commit JetBrains/jewel@c322d7b?file-filters%5B%5D=.kt&show-viewed-files=true, rearranging a few import statements.
Running check on the CI will then succeed.

Thank you.

@rock3r
Copy link
Contributor

rock3r commented Nov 25, 2024

Hi @hick209 any chance y'all can take a look at this? @hamen can help you repro by providing more Jewel commits where this happens. It's very annoying...

@hamen
Copy link
Author

hamen commented Nov 25, 2024

Yeah, it forced me to a very exhausting workflow where I need to:

  • run it on Windows
  • push the code
  • watch the CI failing
  • pull the branch on Linux
  • run it on Linux
  • push the code
  • watch the CI succeed

It's very time-consuming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants