Devcontainer upgrade and implement workaround for #10769 #10770
+57
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e#7029 by using IPv4 loopback when in Remote Container environment
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
7 tasks
slorber
requested changes
Dec 26, 2024
Comment on lines
+1
to
+27
| /** | ||
| * Copyright (c) Facebook, Inc. and its affiliates. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| */ | ||
|
|
||
| import logger from '@docusaurus/logger'; | ||
|
|
||
| export function forceV4OnRemoteContainers( | ||
| userCLIConfig: OptionallyProvidedHost, | ||
| ): void { | ||
| if (process.env.REMOTE_CONTAINERS === 'true') { | ||
| if (!userCLIConfig.host) { | ||
| userCLIConfig.host = '127.0.0.1'; | ||
| logger.info( | ||
| 'Will default to binding to IPv4 local address to better support VSCode Remote port forwarding', | ||
| ); | ||
| } else { | ||
| logger.warn('VSCode Remote may not support IPv6'); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| export type OptionallyProvidedHost = { | ||
| host?: string; | ||
| }; |
There was a problem hiding this comment.
We don't want to add Devcontainer specific things into Docusaurus core.
At best I can propose to implement docusaurus start --host 127.0.0, it's already supported for docusaurus serve. Devcontainer hacks should be added "from the outside"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
Upgrades Dev Container to Ubuntu 24.04 base and Node 22 (latest LTS)
Also migrates VSCode configuration/settings to correct place in schema
Adds a fairly hacky workaround for #10769 where if the
startorservecommands are ran within Remote Containers it will default to127.0.0.1instead oflocalhost. Ideally this would have been a cleaner refactor, or fixed somewhere upstream (ie vscode forwards port correctly, or webpack dev server support dual-stack binding)Test Plan
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs
#10769