Replies: 4 comments 3 replies
-
Offtop: I think such questions are best asked on our Discord/Twitter accounts, no one will know about it here. |
Beta Was this translation helpful? Give feedback.
-
I meant it was necessary to invite to this discussion using the
Twitter/Discord account (to let people know about it).
вс, 24 мая 2020 г. в 15:10, Yangshun Tay <[email protected]>:
… I think discussions is the correct place to do that. Discussions is a new
GitHub feature and I'm not sure if people can see it.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2790 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBUIO3UKXA2UZGFMBAABX3RTEFCZANCNFSM4NHVYANQ>
.
|
Beta Was this translation helpful? Give feedback.
-
Hi, I'm not fan at all of this swizzling thing (also known as shadowing in gatsby). I'd rather have an approach that allows to override components using context, in the same way MDXProvider works. Just expressed some thoughts here, hope to get some feedback: https://twitter.com/sebastienlorber/status/1264599806988767232 |
Beta Was this translation helpful? Give feedback.
-
Chris Biscardi answered me that it's because we don't want to bundle 2 variants of the same code, while only using 1 at runtime. Just saw dynamic imports in a provider in the Dokz project documentation, that could be a solution to this problem!
|
Beta Was this translation helpful? Give feedback.
-
Following up on #2743:
What are your common use cases for swizzling of components? We're coming up with new APIs for theme components so that you can customize them without swizzling. Your feedback will help us shape those APIs.
Let us know in the comments!
Beta Was this translation helpful? Give feedback.
All reactions