Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pytx] Add typed marker, attempt 2 #1360

Merged
merged 1 commit into from
Sep 15, 2023
Merged

[pytx] Add typed marker, attempt 2 #1360

merged 1 commit into from
Sep 15, 2023

Conversation

Dcallies
Copy link
Contributor

Summary

I attempted to add the typed marker in #1356, but I wrongly thought that all I needed was the package information.

Test Plan

I'm trying to figure out how to test this rather than yolo the package, but stumbling.

@github-actions github-actions bot added the python-threatexchange Items related to the threatexchange python tool / library label Sep 13, 2023
@dougneal
Copy link
Contributor

I tested it by pip installing from your git commit hash and re-running mypy on OMM:

pip install --force-reinstall git+https://github.com/facebook/ThreatExchange.git@4009648a6c789269a963c308f80fe5c9831c1828#subdirectory=python-threatexchange

@dougneal dougneal merged commit c283d2d into main Sep 15, 2023
6 checks passed
@dougneal dougneal deleted the py_typed_take_2 branch September 15, 2023 11:20
@Dcallies Dcallies mentioned this pull request Sep 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougneal dougneal dougneal approved these changes

Assignees
No one assigned
Labels
CLA Signed python-threatexchange Items related to the threatexchange python tool / library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dcallies @dougneal @facebook-github-bot