This repository has been archived by the owner on Aug 9, 2024. It is now read-only.
added link to user handles on profile following and followers #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, I hope it works, as I could not test it myself |
GStudiosX2
suggested changes
Jul 29, 2024
src/routes/FollowListPopup.svelte
Outdated
| @@ -100,7 +100,7 @@ | |||
| >{user.iq}</span | |||
| > | |||
| </div> | |||
| <p class="text-sm text-muted-foreground">@{user.handle}</p> | |||
| <p class="text-sm text-muted-foreground"><a href="https://lyntr.com/@{user.handle}">@{user.handle}</a></p> | |||
There was a problem hiding this comment.
It works but please change href to /@{user.handle}
There was a problem hiding this comment.
Ok, I hope I understood the fix correctly, is this bc it uses a hardcoded URL prefix?
There was a problem hiding this comment.
Ok, I hope I understood the fix correctly, is this bc it uses a hardcoded URL prefix?
Yeah because on localhost it will redirect to lyntr.com
|
Sorry can you merge my pr on your fork the anchor and href doesn't work because it doesn't update the currentPage store it also doesn't fully refresh the page so it doesn't go to the follower/following profile unless you manually refresh |
Fix redirect
|
What's the status on this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So hopefully I made it that way now you can click on followings and followers and be redirected to their profile page