Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test coverage not great! #36

Open
developess opened this issue Jul 20, 2018 · 1 comment
Open

Test coverage not great! #36

developess opened this issue Jul 20, 2018 · 1 comment
Labels
SGC

Comments

@developess
Copy link

I'm sure you know this, but your 3 tests are only covering the apirequest function not the 3 others in logic JS. Should be tests for all these modular functions? They're nice pure functions so should be doable.
@sima-qian
Copy link
Collaborator

😢

@sima-qian sima-qian added the SGC label Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
SGC
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sima-qian @developess