Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SNAPSHOT versions #117

Open
ljelinkova opened this issue Jan 16, 2018 · 3 comments
Open

Remove SNAPSHOT versions #117

ljelinkova opened this issue Jan 16, 2018 · 3 comments
Labels
Milestone

Comments

@ljelinkova
Copy link
Collaborator

The Fabric8 plugin uses snapshot version of the LSP server and of the lsp4j plugin. These should be replaced by some released version.

@geetikabatra
Copy link
Collaborator

Last time I checked, the released version was not working as desired. The errors were not being flagged using the released version. That is why we adopted to Snapshot version. If released version works well, we can replace the snapshot version with it.

@nickboldt
Copy link
Contributor

nickboldt commented Jan 16, 2018

Assuming you're talking about 0.0.5 vs. 0.0.6-SNAPSHOT, then to use the 0.0.5 release we'll have to hack up a change to the job that publishes the zip so that the fabric8 analytics plugin can find it at build time. The fix I provided to publish a ZIP as well as a TAR is only in 0.0.6-SNAPSHOT, not 0.0.5.

Alternately, maybe we could fork the repo from 0.0.5, apply my changes, and release a 0.0.5.1 ?

Other than the fact that it's a bad code smell to depend on a SNAPSHOT version when you're doing a GA release, what's wrong with the 0.0.6-SNAPSHOT server? Considering the fabric8 analytics are Technology Preview and at version 0.0.1, I don't think it's an issue to use a SNAPSHOT version for this release in devstudio 11.2.0.GA. ... unless there's a TECHNICAL reason that 0.0.6-SNAPSHOT is bad, other than its version.

Once you get to 1.0 (no longer Tech Preview), then yes, it's time to ONLY use RELEASE versions. But for now, it's acceptable IMO.

@ljelinkova
Copy link
Collaborator Author

Thanks Geetika and Nick for the explanation that it is OK for tech preview to have SNAPSHOT releases. I'll leave this issue open so that it will be fixed in 1.0.0 release.

@ljelinkova ljelinkova added Low and removed High labels Jan 17, 2018
@ljelinkova ljelinkova added this to the 1.0.0 milestone Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants