Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please improve code coverage for new code added via PR #33 #34

Open
tisnik opened this issue Mar 8, 2019 · 0 comments
Open

Please improve code coverage for new code added via PR #33 #34

tisnik opened this issue Mar 8, 2019 · 0 comments
Assignees
@animuk
Labels
bug Something isn't working enhancement New feature or request

Comments

@tisnik
Copy link
Member

tisnik commented Mar 8, 2019

Unit test code coverage decreased under 70%:
#33

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
- Coverage   71.53%   69.12%   -2.42%     
==========================================
  Files           2        2              
  Lines         274      353      +79     
==========================================
+ Hits          196      244      +48     
- Misses         78      109      +31
@tisnik tisnik added bug Something isn't working enhancement New feature or request labels Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@animuk animuk

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tisnik @animuk