Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please refactor the function normalize_worker_data #28

Open
tisnik opened this issue Mar 4, 2019 · 0 comments
Open

Please refactor the function normalize_worker_data #28

tisnik opened this issue Mar 4, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@tisnik
Copy link
Member

tisnik commented Mar 4, 2019

The following part of code needs to be refactored into at least three parts:

  1. fetching input data
  2. processing/normalizing them
  3. preparing results

def normalize_worker_data(self, start_date, end_date, stack_data, worker, frequency='weekly'):

Additionally I feel that the part where data is written back into the S3 should not be there - at least the function name suggests that just the 'normalization' is done, and the state of app is not changed otherwise.

@tisnik tisnik added the enhancement New feature or request label Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant