Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Fable 5 to be used with Fable 4 plugins #3963

Merged
merged 7 commits into from
Nov 26, 2024

Conversation

ncave
Copy link
Collaborator

@ncave ncave commented Nov 25, 2024

@MangelMaxime
Copy link
Member

Thank you @ncave.

I added some simple tests to covert our needs.

I think in the future, we will need a more specific logic to manual control the range of which version of Fable support which version of Fable.AST but for our current needs it should work fine.

Waiting for the CI to confirm that that all is still good before making a new release

@MangelMaxime
Copy link
Member

@ncave I added what I think was a missing parenthesis but even with that a test is still failing on the CI.

It works on my machine... do you have an idea?

@ncave
Copy link
Collaborator Author

ncave commented Nov 25, 2024

@MangelMaxime

I added what I think was a missing parenthesis

No, that's not going to change anything, the operator precedence is the same.
It must be something else.

@MangelMaxime
Copy link
Member

I think I was just tired, I was not running the correct tests locally.

And it appears that in my tests, I had the argument order inverted.

Waiting for the CI to confirm that all is good now 🤞

@MangelMaxime MangelMaxime changed the title Updated plugin version check Allow Fable 5 to be used with Fable 4 plugins Nov 26, 2024
@MangelMaxime MangelMaxime merged commit a97e712 into fable-compiler:main Nov 26, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fable 5, not compatible with Fable 4 plugins
2 participants