Refactor time_span.py to use an int representation instead of timedelta #3608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion can handle it just fine
MangelMaxime
force-pushed
the
feature/timespan_as_number
branch
from
48960a1 to
f17051f
Compare
MangelMaxime
changed the title
…anoseconds` + Update changelog
dbrattli
reviewed
Nov 25, 2023
dbrattli
reviewed
Nov 25, 2023
dbrattli
reviewed
Nov 25, 2023
dbrattli
reviewed
Nov 25, 2023
dbrattli
reviewed
Nov 25, 2023
dbrattli
reviewed
Nov 25, 2023
dbrattli
reviewed
Nov 25, 2023
|
Looks good, just remember all variables should be |
dbrattli
approved these changes
Nov 25, 2023
|
Right, thank you for the review. I fixed the naming, I will release a new version of Fable tomorrow or on monday, I think we already have a lot of improvement made in the main branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TotalXXX,Days,Seconds, etc. returns the expected valueTimeSpan precision is at the Ticks levels, in .NET the precision is nanoseconds but I have no idea how to implement it correctly.
The TimeSpan constructor goes up to
Ticklevels so we can't create aTimeSpanbased on the nanosecond value.For this reason, I am making Fable emit an error if the user tries to use any of the
Nanosecondsgetter.