Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP fix for #3496 #3505

Closed
wants to merge 1 commit into from
Closed

WIP fix for #3496 #3505

wants to merge 1 commit into from

Conversation

smoothdeveloper
Copy link
Contributor

Not to be merged as it fails test Can type test interfaces decorated with Global in TestPyInterop.

I'm not sure how to deal with this, it would be needed to resolve the [<Global("Array")>] attribute adorned to PyArray or some other approach.

cc: @dbrattli

@smoothdeveloper
inching toward fix for fable-compiler#3496, albeit it fails ``test Ca…
81026a1 
…n type test interfaces decorated with Global`` in TestPyInterop
@dbrattli
Copy link
Collaborator

I'm currently trying to refactor things so x,Length is not translated to len(x) since length is not an interface member and should not be translated to __len__ protocol in Python. Perhaps restrict to ICollection.Count to be automatically translated to __len__ and x.Count() to become len(x).

@dbrattli dbrattli added the python Python label Oct 11, 2023
@dbrattli
Copy link
Collaborator

I've merged the test from this PR into #3540 so closing this PR in favour of #3540

@dbrattli dbrattli closed this Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
python Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smoothdeveloper @dbrattli