Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyboard overhaul #1

Open
1 of 2 tasks
fabiangreffrath opened this issue Jun 30, 2023 · 1 comment
Open
1 of 2 tasks

keyboard overhaul #1

fabiangreffrath opened this issue Jun 30, 2023 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@fabiangreffrath
Copy link
Owner

fabiangreffrath commented Jun 30, 2023

Keyboard handling needs a serious overhaul.

We need to:

  • read out scancodes for controls
  • symbols for entered text (e.g. savegames, cheat codes and highscore table)
@fabiangreffrath fabiangreffrath added the help wanted Extra attention is needed label Jun 30, 2023
@fabiangreffrath
Copy link
Owner Author

We need to read out scancodes for controls

This could be achieved rather easy in 1808cf0

and symbols for entered text (e.g. savegames, cheat codes and highscore table).

However, I doubt that this can be achieved with reasonable effort. The main reason is that SDL keyboard events are not read out on a regular base (e.g. once per gametic, as in Doom), but are pumped on demand by several concurring functions and are then enqueued after applying some filtering rules.

The keyboard code is a mess, which should be incentive enough to overhaul it. However, I have spent several hour working on a cleaner approach but without success. It works as expected now, so I'll probably leave it as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant