forked from sunspot/sunspot
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BlockJoin improvements for Rails applications #23
Open
DougKeller
wants to merge
20
commits into
extendi:master
Choose a base branch
from
SynergyDataSystems:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We ultimately ended up going a different route than BJQ for our app due to issues with keeping parent/child docs in sync, so I have deleted our fork of this branch. I'll still leave this PR open in case there's anything valuable in it, however it's unmaintained and isn't totally bug-free. |
Hi @DougKeller thank you for the PR, we'll review it. I'm sure there some valuable stuff here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your PR - because this isn't part of the official branch yet, we chose to try out your changes for our Solr needs.
That said, there were a few changes/improvements we had to make to get it up and running for our app. Unfortunately these changes haven't been tested due to time constraints, but I wanted to put up this PR for you to consider some things that may have been missed.
Changes:
child_documents
valuetype
all_parents_filter
, facet values were coming back incorrectly. Changing this to only filter ontype:parent
fixed the counts.name
correctly_childDocuments_
in its field list, serialize each_childDocuments_
value as aSunspot::Search::Hit
order_by :some_field, :desc, block_join: on_child(Child) { with(...) }