We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I suggest making the methods of the session object in the request async , mostly for session.destroy.
session.destroy
I've found myself doing this in NestJS:
return new Promise(resolve => session.destroy(() => resolve())
Would become:
@Get('logout') public logout(): Promise<void> { return session.destroy() }
and:
@Get('logout') public async logout(): Promise<void> { await session.destroy() // Promise<void> Logger.log('Destroying the session...') return }
And making the callback optional.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
I suggest making the methods of the session object in the request async , mostly for
session.destroy
.I've found myself doing this in NestJS:
Would become:
and:
And making the callback optional.
The text was updated successfully, but these errors were encountered: