Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to build for package CLI #13108

Closed

Conversation

adrianeboyd
Copy link
Contributor

Description

Switch to build for package CLI.

Types of change

Enhancement?

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@adrianeboyd
Copy link
Contributor Author

adrianeboyd commented Nov 5, 2023

python setup.py bdist_wheel already shows warnings that it's deprecated and I suspect that python setup.py sdist will follow (although I haven't been following the details here carefully). In general calling python setup.py in any way is discouraged.

It's not a hassle exactly, but detecting whether build is installed is annoying. We could consider just adding build as a dependency and removing the check. We don't currently have wheel as a dependency, but it's everywhere in our install instructions with pip install -U pip setuptools wheel in a way that I wouldn't add build. Actually I think we could update this to pip install -U pip instead since the other tools don't need to be installed separately in typical (non-dev) cases, and setuptools is included in requirements.txt.

As an argument against including it: build currently requires importlib_metadata for python <3.10.2.

@adrianeboyd adrianeboyd closed this Nov 5, 2023
@adrianeboyd adrianeboyd reopened this Nov 5, 2023
@adrianeboyd
Copy link
Contributor Author

We could also fall back to the previous sdist/bdist_wheel methods if build isn't installed, and then this could potentially target master instead. But build is the (current) future-friendly option.

@adrianeboyd adrianeboyd added enhancement Feature requests and improvements feat / cli Feature: Command-line interface labels Nov 6, 2023
@adrianeboyd
Copy link
Contributor Author

Closing in favor of #13109.

@adrianeboyd adrianeboyd closed this Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests and improvements feat / cli Feature: Command-line interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant