-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from pathy to cloudpathlib #11750
Switch from pathy to cloudpathlib #11750
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question about the changes but looks good.
The test should probably be marked slow in the end. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like #11780 introduced a minor conflict in the docs, so I went ahead and resolved that.
Besides that the most recent change looks fine.
Changes based on spaCy PR. explosion/spaCy#11750
I'll close this for now since the issues with |
Hi, I noticed that |
Yes it would, thanks for the note! Neither of them currently support python 3.12, however. |
Actually, Pathy should have just been removed from spacy, it's no longer used. |
Description
Switch from
pathy
tocloudpathlib
for remote storage withspacy project push/pull
.smart_open
for downloads, which are also used for project assets.cloudpathlib
for uploads.ignore_ext
flag withcompression
and add correspondingsmart_open
version requirements.Types of change
Enhancement.
Checklist