fix: Update error handling in Faithfulness metric to return 0.0 instead of np.nan on failure #1773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of np.nan on failure
dosubot
bot
added
the
size:XS
|
Hi, we have made it return nan by design. Zero here means no hallucinations and NaN means undetermined. Here the case the latter and not the former. While processing the results, the user may fill the NaNs in the results according to his/her best judgement. Please close the PR if this explanation makes sense to you. @iamarunbrahma |
|
Thanks for the explanation, @shahules786. That makes sense. Closing this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a KeyError: 0 issue that occurs when running RAG evaluation metrics, specifically in the faithfulness metric computation.
Fixes #1770