Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Innovimax patch to compiler with saxon97 #87

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

innovimax
Copy link

No description provided.

@cirulls
Copy link

cirulls commented Jan 17, 2017

@innovimax : Thanks for the contribution. Does this pull request fix the code coverage? This was fixed in XSpec release v0.5.0, the development moved to https://github.com/xspec/xspec (I don't have write permissions on the expath/xspec repository).

I had a quick look at your changes with what is currently implemented in https://github.com/xspec/xspec/blob/master/java/com/jenitennison/xslt/tests/XSLTCoverageTraceListener.java and they look very similar. If you notice anything different or if your pull request also addresses other things, could you initiate a pull request on https://github.com/xspec/xspec so that I can properly check the diff files?

Thanks,

Sandro

@innovimax
Copy link
Author

hello @cirulls !

Yess indeed it has been already fixed (I saw that later and did update my branch after that)

@cirulls
Copy link

cirulls commented Jan 17, 2017

Thanks for confirming. If you have other pull requests or feature requests do not hesitate to send them to https://github.com/xspec/xspec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants