Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credit where credit is due #4

Open
joshgoebel opened this issue May 5, 2021 · 8 comments
Open

Credit where credit is due #4

joshgoebel opened this issue May 5, 2021 · 8 comments

Comments

@joshgoebel
Copy link
Contributor

joshgoebel commented May 5, 2021

It seems easiest to start by copying many of the great Javascript exercises and then porting them to Wren. In many cases the instructions may even work as-is (though perhaps this will change as the exercises get harder). Hopefully many of the test suits will work (after reworking syntax/porting slightly, etc). The Wren solutions I'm writing from scratch.

Obviously in some cases the exercises will need to change or be rethought because the language is different, but I think I can get a long ways for many exercises by taking advantage of the hard work already put in on the JS side.

So... if I'm starting with the foundation of using JS exercises... what information should go in the author and contributor blocks for config.js for each exercise? Should I be the new author? Should the contributors from JS be left in place? Should it all reset to zero because it's now Wren?

I don't want to borrow without giving credit where it's due so I want to do the right thing here whatever that is.

@joshgoebel
Copy link
Contributor Author

@iHiD

@ErikSchierboom
Copy link
Member

So... if I'm starting with the foundation of using JS exercises... what information should go in the author and contributor blocks for config.js for each exercise? Should I be the new author? Should the contributors from JS be left in place? Should it all reset to zero because it's now Wren?

You should be the sole author and the JS contributors should be removed, so yes: it should reset.

To still attribute the original source, we support a forked_from property (see the docs) for Concept Exercises, but we didn't yet define it for Practice Exercises. It might make sense to do so judging from your comment. Do you agree @iHiD?

@iHiD
Copy link
Member

iHiD commented May 5, 2021

I think because the idea is that Problem Specifications is the central space, we don't have forked_from.

So I guess the question is, are these great JS exercises, or great Problem Specifications exercises?

@ErikSchierboom
Copy link
Member

Yes that is indeed the idea, but for the implementer, there is hardly any difference between forking a Concept Eexercise versus a Practice Exercise. In both cases someone else will have done a lot of the groundwork to implement the exercise. So there is an argument to be made that Practice Exercises can also be forked from another track, to reward the forked exercise's author.

@iHiD
Copy link
Member

iHiD commented May 5, 2021

That makes sense. But I imagine if you compare say the JS exercises to any other track, they'll be relatively similar? ie, the credit isn't simply due for one existing track that the new track is copying from, but for the whole PS team?

@ErikSchierboom
Copy link
Member

🤷 They will indeed be similar across tracks, although the implementation is of course still track-specific. But yeah, it is not as straightforward as for Concept Exercises.

@joshgoebel
Copy link
Contributor Author

Any more thoughts here?

@ErikSchierboom
Copy link
Member

At least for now, just put yourself as the author. We'll look at this in more detail once everything has stabilized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants