-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Credit where credit is due #4
Comments
You should be the sole author and the JS contributors should be removed, so yes: it should reset. To still attribute the original source, we support a |
I think because the idea is that Problem Specifications is the central space, we don't have So I guess the question is, are these great JS exercises, or great Problem Specifications exercises? |
Yes that is indeed the idea, but for the implementer, there is hardly any difference between forking a Concept Eexercise versus a Practice Exercise. In both cases someone else will have done a lot of the groundwork to implement the exercise. So there is an argument to be made that Practice Exercises can also be forked from another track, to reward the forked exercise's author. |
That makes sense. But I imagine if you compare say the JS exercises to any other track, they'll be relatively similar? ie, the credit isn't simply due for one existing track that the new track is copying from, but for the whole PS team? |
🤷 They will indeed be similar across tracks, although the implementation is of course still track-specific. But yeah, it is not as straightforward as for Concept Exercises. |
Any more thoughts here? |
At least for now, just put yourself as the author. We'll look at this in more detail once everything has stabilized. |
It seems easiest to start by copying many of the great Javascript exercises and then porting them to Wren. In many cases the instructions may even work as-is (though perhaps this will change as the exercises get harder). Hopefully many of the test suits will work (after reworking syntax/porting slightly, etc). The Wren solutions I'm writing from scratch.
Obviously in some cases the exercises will need to change or be rethought because the language is different, but I think I can get a long ways for many exercises by taking advantage of the hard work already put in on the JS side.
So... if I'm starting with the foundation of using JS exercises... what information should go in the
author
andcontributor
blocks forconfig.js
for each exercise? Should I be the new author? Should the contributors from JS be left in place? Should it all reset to zero because it's now Wren?I don't want to borrow without giving credit where it's due so I want to do the right thing here whatever that is.
The text was updated successfully, but these errors were encountered: