Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matrix: inconsistent test #428

Open
SunCatMC opened this issue Jan 6, 2021 · 3 comments
Open

matrix: inconsistent test #428

SunCatMC opened this issue Jan 6, 2021 · 3 comments
Assignees

Comments

@SunCatMC
Copy link
Contributor

SunCatMC commented Jan 6, 2021

The test "extract column from diff widths matrix" is not the same as the test "extract column where numbers have different widths" in problem-specification, as it has multiple spaces in between matrix values, compared to original one-space test.

I don't know how you handle differences in specification and actual exercises, but if it's ok to have them, there should be consistency, as you can have a solution that accounts for multiple spaces in columns but doesn't in rows (as the test for rows "extract row from diff widths matrix" is exactly the same as the one in specification)

@ErikSchierboom
Copy link
Member

Tracks are in principle free to diverge from the canonical data as defined in prob-specs. This is usually only done when a test doesn't fit a track. The exercise should indeed be consistent. Would you be interested in submitting a PR to fix this?

@SunCatMC
Copy link
Contributor Author

SunCatMC commented Jan 7, 2021

Sure, I can submit a PR

I guess changing it to match the specification is better, as this way you don't get a non-obvious point of failure for such a simple puzzle

@ErikSchierboom
Copy link
Member

Agreed! That would definitely be best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants