Alphametics tests to handle timeouts for longer tests

[martinfreedman]

Changed alphameticstests.fs to make all tests async and added xunit Timeout attribute to longest 3 tests with 2 secs for Puzzle with eight letters and 5 seconds each for Puzzle with ten letters and 199 addends and Puzzle with ten letters exercises.

And switch back on testrunner for this exercise.

[ErikSchierboom]

Nice idea. The actual timeouts are slightly tricky to determine, but I'm fine with having some value here. That said, we currently can't merge this as the test runner will strip the attribute before it runs the tests:

type EnableAllTests() =
    inherit SyntaxVisitor()

    override _.VisitSynAttribute(attr: SynAttribute) : SynAttribute =
        match attr.TypeName with
        | LongIdentWithDots ([ ident ], _) when ident.idText = "Fact" ->
            base.VisitSynAttribute
                { attr with
                      ArgExpr = SynExpr.Const(SynConst.Unit, attr.ArgExpr.Range) }
        | _ -> base.VisitSynAttribute(attr)

Would you be interested in fixing that too?

[martinfreedman]

Yup will have a look at that shortly.

[martinfreedman]

Will look at this. Which repo and file is it?

[martinfreedman]

I think timeouts should be discussed at the practise exercise specification, hence my other PR to update canonical json with a timeout property. This might include relative timings between tests as implied here between 8 versus 10 letter tests. The actual implementation would depend on the track maintainers factoring in the built in online test runner timeouts and language performance etc. I would probably default to 10 seconds per test, a propos of anything more specific.

[martinfreedman]

I already wrote a reply but it has inexplicably disappeared. What files do I need to look at?

[ErikSchierboom]

See #1029 (comment). I should have posted that comment here.

[ErikSchierboom]

@martinfreedman Let me know if you need any help/pointers. The F# syntax tree can be tricky to work with.

[martinfreedman]

Will do. And yes the Diamond exercise does not use [<Fact>]! I will add this into my solution when I have a chance (I have Covid right now). Any other exercises tests with non-standard Attributes?

[ErikSchierboom]

(I have Covid right now)

Oh no! All the best.

Any other exercises tests with non-standard Attributes?

The simple-linked-list exercise uses a [<Theory>] attribute (which should actually be converted to multiple [<Fact>] attributes.

[ErikSchierboom]

Which repo and file is it?

This one: https://github.com/exercism/fsharp-test-runner/blob/main/src/Exercism.TestRunner.FSharp/Rewrite.fs#L20

I think timeouts should be discussed at the practise exercise specification, hence my other PR to update canonical json with a timeout property. This might include relative timings between tests as implied here between 8 versus 10 letter tests. The actual implementation would depend on the track maintainers factoring in the built in online test runner timeouts and language performance etc. I would probably default to 10 seconds per test, a propos of anything more specific.

I'm not entirely sure about the timeouts being in the prob-specs definition, but I'll post my thoughts there.

Oh and I completely forgot to mention that the alphametics exercise's test file is automatically generated by a test generator: https://github.com/exercism/fsharp/blob/main/generators/Generators.fs#L61 That means that any changes that are not made to the generator would be overwritten when we re-generate the tests. I think you can ignore that for now, as the F# test generator hasn't yet been updated to use the tests.toml file (I started working on that), but I did want to mention it.

[ErikSchierboom]

Speaking of the tests.toml file, that would be a great place to configure these timeouts.