Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-activate mounting of test folders #37

Open
tomuben opened this issue Jun 9, 2021 · 0 comments
Open

Re-activate mounting of test folders #37

tomuben opened this issue Jun 9, 2021 · 0 comments
Labels
refactoring Code improvement without behavior change

Comments

@tomuben
Copy link
Collaborator

tomuben commented Jun 9, 2021

Background

The test environment currently has some assumptions about the folder structure of the respective python test files.
At some places the folders are manipulated manually (for example here and here.
This does not work with the mount solution of #10, and hence the mounting for test folders was removed in #26.

Acceptance Criteria

Re-activate the mounting here and adjust the test environment to work correctly.
@tomuben tomuben added bug Unwanted / harmful behavior source:exasol labels Jun 9, 2021
tomuben added a commit that referenced this issue Jun 9, 2021
@tomuben
Deactivate mounting of test folder temporarily as it causes issues wi…
0462557 
…th test environment.

-> #37
tomuben added a commit that referenced this issue Jun 9, 2021
@tomuben
#26:Using host network for execution of exasclt (#36)
1db615a 
* #26:Using host network for execution of exasclt

In case of exasclt upload the user might try to push image to a custom network path. For that we need to execute the exasclt docker instance in the host network, not the isolated docker network.

Also, execute tests within container, by using exaslct script instead of starter_scripts/exaslct_without_poetry.sh

* Deactivate mounting of test folder temporarily as it causes issues with test environment.
-> #37

Fixes #26.
@tomuben tomuben added feature Product feature and removed bug Unwanted / harmful behavior labels Jun 9, 2021
@redcatbear redcatbear added refactoring Code improvement without behavior change and removed feature Product feature labels Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Code improvement without behavior change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@redcatbear @tkilias @tomuben