Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ITDE startup functions #93

Closed
ckunki opened this issue Mar 25, 2024 · 0 comments · Fixed by #97
Closed

Refactor ITDE startup functions #93

ckunki opened this issue Mar 25, 2024 · 0 comments · Fixed by #97
Labels
refactoring Code improvement without behavior change

Comments

@ckunki
Copy link
Collaborator

ckunki commented Mar 25, 2024

See also

Acceptance criteria

In file exasol/nb_connector/itde_manager.py

  • Rename start_itde() to restart_itde()?
  • Rename method is_itde_running() to is_itde_ready().
  • Refactor function is_itde_running() to return an enum rather than a tuple (see below)
class ItdeContainerStatus(Enum):
    EXISTS = 0
    RUNNING = 1

This would also enable to handle the case not container_name or not network_name more explicitly by returning None or having an explicit enum value UNKNOWN or INVALID.

@ckunki ckunki added the refactoring Code improvement without behavior change label Mar 25, 2024
@ckunki ckunki changed the title Refactor Refactor ITDE startup functions Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code improvement without behavior change
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant