Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#418: Introducing python toolbox #421

Merged
merged 33 commits into from
Nov 19, 2024
Merged

#418: Introducing python toolbox #421

merged 33 commits into from
Nov 19, 2024

Conversation

tomuben
Copy link
Collaborator

@tomuben tomuben commented Nov 18, 2024 •
edited
Loading

fixed #418

All Submissions:

  • Is the title of the Pull Request correct?
  • Is the title of the corresponding issue correct?
  • Have you updated the changelog?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Are you mentioning the issue which this PullRequest fixes ("Fixes...")
  • Before you merge don't forget to run all tests for all Exasol version, by adding [run all tests] to the commit message
  • Are the CLI usage examples up to date?

tomuben
tomuben commented Nov 18, 2024
View reviewed changes
.github/workflows/checks.yml Outdated Show resolved Hide resolved
@tkilias tkilias changed the title #418: introduced python toolbox #418: Introducing python toolbox Nov 18, 2024
tkilias
tkilias requested changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@tkilias tkilias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left comments and did you remove the checksums for the starter scripts with purpose?

.pre-commit-config.yaml Outdated Show resolved Hide resolved
.github/workflows/test_python_version.yml Outdated Show resolved Hide resolved
ckunki
ckunki requested changes Nov 19, 2024
View reviewed changes
.gitattributes Outdated Show resolved Hide resolved
.github/workflows/merge-gate.yml Outdated Show resolved Hide resolved
@tomuben
[run all tests]
67d9cab
@tomuben
1. Override unit test nox task
577f86b 
2. Decreased lint rating slightly
3. Removed `coverage report -m` from tests.yml
@tomuben
[run all tests]
e898cf0
tkilias
tkilias reviewed Nov 19, 2024
View reviewed changes
noxfile.py Outdated
session.run("git", "add", str(target_path))

@nox.session(name="lint:security", python=False)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is a hotpatch, please create a ticket that it gets replaced

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, Nico already fixed it in version 0.18.0. Will update dependencies and try again without it

tkilias
tkilias previously approved these changes Nov 19, 2024
View reviewed changes
ckunki
ckunki approved these changes Nov 19, 2024
View reviewed changes
.github/workflows/pr-merge.yml

jobs:

# This job can be removed if certain preconditions are met. See
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally would remove this job

@tomuben tomuben merged commit e6d4177 into main Nov 19, 2024
109 checks passed
@tomuben tomuben deleted the refactoring/418_introduce_python_toolbox branch November 19, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nicoretti Nicoretti Nicoretti left review comments

@ckunki ckunki ckunki approved these changes

@tkilias tkilias tkilias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce Python-Toolbox
4 participants
@tomuben @Nicoretti @tkilias @ckunki