Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate two-level ADMM with AdmmEnv #24

Merged
merged 6 commits into from
May 24, 2021
Merged

Integrate two-level ADMM with AdmmEnv #24

merged 6 commits into from
May 24, 2021

Conversation

kibaekkim
Copy link
Member

Tested on cpu and gpu with case9

@kibaekkim kibaekkim requested review from frapac and youngdae May 22, 2021 01:43
@kibaekkim kibaekkim linked an issue May 22, 2021 that may be closed by this pull request
Integrate two-level algorithm in the new interface AdmmEnv #21
Closed
frapac
frapac requested changes May 22, 2021
View reviewed changes
Copy link
Member

@frapac frapac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It overall looks good to me! I think this will ease the integration of ProxAL inside ExaTron.
Once this PR merged, it would be nice to test properly the two level algorithm. Once #24 is merged, I could take care of that.

src/admm/acopf_admm_gpu.jl Show resolved Hide resolved
src/admm/acopf_admm_gpu.jl Outdated Show resolved Hide resolved
src/admm/environment.jl Show resolved Hide resolved
src/admm/environment.jl Outdated Show resolved Hide resolved
src/admm/environment.jl Outdated Show resolved Hide resolved
src/admm/environment.jl Outdated Show resolved Hide resolved
youngdae
youngdae approved these changes May 24, 2021
View reviewed changes
Copy link
Member

@youngdae youngdae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Francois' comments. Other than that, it looks good to me.

frapac
frapac approved these changes May 24, 2021
View reviewed changes
Copy link
Member

@frapac frapac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@kibaekkim kibaekkim merged commit 54e4ce8 into youngdae/gpu-admm May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frapac frapac frapac approved these changes

@youngdae youngdae youngdae approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate two-level algorithm in the new interface AdmmEnv
3 participants
@kibaekkim @youngdae @frapac