fix tests if AMDGPU is not available

[frapac]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c0d69a6) 63.33% compared to head (3cbe3bf) 69.45%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #285      +/-   ##
==========================================
+ Coverage   63.33%   69.45%   +6.11%     
==========================================
  Files          34       35       +1     
  Lines        4484     4488       +4     
==========================================
+ Hits         2840     3117     +277     
+ Misses       1644     1371     -273     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[michel2323]

The test failing with ERROR: LoadError: ArgumentError: Unknown component :hsa is an issue JuliaGPU/AMDGPU.jl#564 with AMDGPU.jl. AMDGPU.jl should be loadable without an AMD GPU present, just like CUDA.jl. I'd prefer to have the tests being dependent on both packages. In particular, this does not resolve the issue if a user wants to use ExaPF and loads AMDGPU for some reason on a system without AMD GPUs.

[michel2323]

AMDGPU.functional() works as expected. Using that now to guard has_rocm_gpu().

[frapac]

Ok to keep both AMDGPU and CUDA in the tests. But I feel somewhat uncomfortable with the current status: it looks to heavy in term of dependencies.

[frapac]

I think the subpackage TestPolarForm should not depend on any particular AD backend. I would prefer testing it using the previous fix:

if startswith(string(device), "ROCBackend")
    ....

[michel2323]

Ah ok. Makes sense. Ah yes, that's for marking the broken second-order stuff with AMD.

[michel2323]

Ok to keep both AMDGPU and CUDA in the tests. But I feel somewhat uncomfortable with the current status: it looks to heavy in term of dependencies.

AMGPU and CUDA are not dependencies of ExaPF. I am not sure I understand.

[michel2323]

@frapac So keeping CUDA.jl and AMDGPU.jl together in the tests and removing GPU packages from TestPolarForm.jl.