From 34cb0d2966dcc1e513bb8c4af36a91b51119f0b3 Mon Sep 17 00:00:00 2001 From: Alexis Montoison <35051714+amontoison@users.noreply.github.com> Date: Thu, 7 Dec 2023 11:24:45 -0600 Subject: [PATCH] Add a workflow with Aqua.jl (#289) * Add a workflow with Aqua.jl * Remove undefined exported symbols * Add a compat entry for AMDGPU.jl --- .github/workflows/Aqua.yml | 17 +++++++++++++++++ Project.toml | 1 + src/LinearSolvers/LinearSolvers.jl | 4 ++-- 3 files changed, 20 insertions(+), 2 deletions(-) create mode 100644 .github/workflows/Aqua.yml diff --git a/.github/workflows/Aqua.yml b/.github/workflows/Aqua.yml new file mode 100644 index 00000000..e7b9fe90 --- /dev/null +++ b/.github/workflows/Aqua.yml @@ -0,0 +1,17 @@ +name: Aqua +on: + push: + branches: + - main + pull_request: + types: [opened, synchronize, reopened] +jobs: + build: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v3 + - uses: julia-actions/setup-julia@latest + with: + version: '1' + - name: Aqua.jl + run: julia --color=yes -e 'using Pkg; Pkg.add("Aqua"); Pkg.develop(path="."); using Aqua, ExaPF; Aqua.test_all(ExaPF, ambiguities=false); Aqua.test_ambiguities(ExaPF)' diff --git a/Project.toml b/Project.toml index 4b99f9e2..71caa435 100644 --- a/Project.toml +++ b/Project.toml @@ -26,6 +26,7 @@ ExaPFCUDAExt = "CUDA" [compat] Adapt = "3.3" +AMDGPU = "0.8" CUDA = "4.1, 5" ForwardDiff = "0.10" KernelAbstractions = "0.9" diff --git a/src/LinearSolvers/LinearSolvers.jl b/src/LinearSolvers/LinearSolvers.jl index 07911394..0eab6882 100644 --- a/src/LinearSolvers/LinearSolvers.jl +++ b/src/LinearSolvers/LinearSolvers.jl @@ -22,8 +22,8 @@ using KrylovPreconditioners const KA = KernelAbstractions const KP = KrylovPreconditioners -export bicgstab, list_solvers, default_linear_solver -export DirectSolver, BICGSTAB, EigenBICGSTAB, Bicgstab +export list_solvers, default_linear_solver +export DirectSolver, Bicgstab export do_scaling, scaling! @enum(