Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes convert call #98

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Fixes convert call #98

merged 2 commits into from
Dec 21, 2023

Conversation

julia-script
Copy link
Contributor

ERC20TokensByNameInternal was checking the denom against the file name, which it didn't match in the case of wormhole tokens

this changes the logic a bit to check by the internal cosmos denom

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Collaborator

@Mrsirdev Mrsirdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

codeclimate bot commented Dec 21, 2023

Code Climate has analyzed commit 550910d and detected 0 issues on this pull request.

View more on Code Climate.

@julia-script julia-script merged commit 336036e into main Dec 21, 2023
12 of 13 checks passed
@julia-script julia-script deleted the julia/convertfix branch December 21, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants