Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make this library properly handle caching #141

Open
pequalsnp opened this issue Dec 1, 2017 · 2 comments
Open

Make this library properly handle caching #141

pequalsnp opened this issue Dec 1, 2017 · 2 comments

Comments

@pequalsnp
Copy link

I'd love to use (and contribute to) this library, but it doesn't look look like it handles ESI caching properly.

Unless I'm misreading the code, it seems like you only ever cache (using memoize) the first response for every API call. If I'm missing something, feel free to close this issue.
@biow0lf
Copy link
Member

biow0lf commented Dec 7, 2017

@pequalsnp how you plan use this information? Can you show examples?

Right now, library designed to make one API call to ESI and parse data. All other stuff is out of scope now.

@biow0lf
Copy link
Member

biow0lf commented Dec 11, 2017

Ping @pequalsnp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@biow0lf @pequalsnp