Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks for scenario hub #2

Open
kathsherratt opened this issue Feb 28, 2022 · 3 comments
Open

Checks for scenario hub #2

kathsherratt opened this issue Feb 28, 2022 · 3 comments

Comments

@kathsherratt
Copy link
Contributor

kathsherratt commented Feb 28, 2022

We may need to edit some of the validations to accept scenario hub submissions.

For now I can think of:

  • csv files
  • Metadata includes extra fields
  • Team folder can include an Abstract.md file (although maybe the check shouldn't fail if there isn't one). (Not sure if our current checks flag if there are non-csv or metadata files at the moment so this may not need any action.)
@Bisaloo
Copy link
Member

Bisaloo commented Mar 1, 2022

Most of this is already implemented in the schema files:

I want to try to do a test submission this week but I have been too busy until now.

@kathsherratt
Copy link
Contributor Author

kathsherratt commented Mar 2, 2022

Great that this is mostly implemented!

I was wondering if it would help to have for each round to have a round-specific metadata or config type file that could be used for these validations.

This would include checks that need to happen for each forecast file but are round specific. For instance, the scenario IDs, accepted start/end dates for projections, and the number of weeks allowed should all be checked against a pre-specified list of valid values, but these values can/will each change for each round. I guess we wouldn't want to have to edit a basic schema files each time for these.

I am not sure how difficult it would be to add this functionality to the package, and there could be a better way of doing this - what do you think?

@Bisaloo
Copy link
Member

Bisaloo commented Mar 2, 2022

Since the schema files are located in the repo (covid19-forecast-hub-europe/covid19-scenario-hub-europe in this case), I believe it's fine to edit the relevant lines in the schema files each time.

If we go this route, then no change in required in the ForecastHubValidations package.

@Bisaloo Bisaloo transferred this issue from european-modelling-hubs/HubValidations Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants