connman_curses will try to connect to a protected network with an empty password

[javier-lopez]

Hello,

Thanks for the awesome program, lately I've been playing with connman_curses and found a strange behavior when failed to set a password for a protected (wpa/personal) network.

Testcase

1. Open connman_curses
2. Select the wifi technology
3. Select a new cyphred network
4. Leave empty the credentials window
5. Select Ok
   • connman_curses fails to connect with the following message
     Invalid argument/value. (I think that's fine because I forgot to insert the password)
6. Press <Esc> to go back to the network list window (In my opinion it should go back to the credentials window instead)
7. Select the previous selected cyphred network
8. Connman tries to connect and fail with the following message (does it try to connect with an empty password?)
   • [ERROR] Unidentified call back: status: -1, jobj: { "ERROR": [ "In progress" ] }

After this the only way to reconfigure the desired network is by restarting connman. (sudo service connman restart)

Expected behavior: Connman_curses should keep asking for credentials while they're not given

[alan-mushi]

Hi,

Connman_curses should keep asking for credentials while they're not given

And it does, here's how everything plays out:

1. connman fires a signal/request from the "agent" (the part responsible of credentials) asking for a password
2. connman_ncurses shows you a pop-up window with the content of the request
3. the user enter his credentials
   * if those credentials are empty (as in your case) you have the error message Invalid argument/value
   * if those credentials are wrong connman will try to connect but obviously fail, then the agent fire another "do you want to retry" signal. If you select yes for this new signal you restart to the first point.

Press to go back to the network list window (In my opinion it should go back to the credentials window instead)

I'm afraid this isn't possible due to the agent signal -> pop-up credential window nature, otherwise you would be responding, to the agent, when no question have been asked.

does it try to connect with an empty password?

I believe so.

[javier-lopez]

It's as you said, if a wrong password is given connman_curses will keep asking for the correct one, if an empty passwords is given then it will just keep trying to connect without asking again. As for your explanation I guess it's connman fault then.

Thanks for the clarification =)

[jobol]

Has someone of you searched on connman side? or contacted someone of connman?

I propose to keep that issue opened until we get an entry in the bug tracker of connman or something like that.

The connman team could say: "you should not send an empty password, just validate your input." In that case, the bug is here.

[alan-mushi]

As for your explanation I guess it's connman fault then.

The Invalid argument/value error is from connman-ncurses actually, so the fact that it tries to connect with an empty password is what surprises me, I will investigate this.

My apologies if the explication was unclear.