Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPU Zipper strategy execution error #33

Open
annamariadziubyna opened this issue Oct 25, 2024 · 3 comments
Open

CPU Zipper strategy execution error #33

annamariadziubyna opened this issue Oct 25, 2024 · 3 comments
Assignees

Comments

@annamariadziubyna
Copy link
Collaborator

annamariadziubyna commented Oct 25, 2024

I am encountering an issue when trying to execute a Zipper strategy on the CPU. The problem occurs specifically with the code provided below.
https://github.com/euro-hpc-pl/SpinGlassEngine.jl/blob/Zipper_CPU/test/mwe.jl
Zrzut ekranu 2024-10-25 o 10 29 14

@bartekGardas
Copy link
Contributor

@tomsmierz this should be an easy fix ...

@bartekGardas
Copy link
Contributor

@lpawela has this been resolved and merged?

@lpawela
Copy link
Member

lpawela commented Nov 8, 2024

There are hard-coded CuArray calls in https://github.com/euro-hpc-pl/SpinGlassTensors.jl/blob/Zipper_CPU/src/contractions/central.jl which probably lead to mixed CPU-GPU matrix multiplications. Probably can be relative easily resolved. The more important question is: why the test suite didn't catch this earlier?

Another problem I encountered when trying to reproduce this using the provided MWE using the code on the master branch is

ERROR: LoadError: UndefVarError: `save_object` not defined
Stacktrace:
 [1] truncate_potts_hamiltonian_2site_BP(potts_h::LabelledGraphs.LabelledGraph{MetaGraphs.MetaDiGraph{Int64, Float64}, Tuple{Int64, Int64, Int64}}, beliefs::Dict{Any, Any}, num_states::Int64, result_folder::String, inst::String; beta::Float64)
   @ SpinGlassNetworks ~/.julia/packages/SpinGlassNetworks/04D6H/src/truncate.jl:132
 [2] truncate_potts_hamiltonian_2site_BP
   @ ~/.julia/packages/SpinGlassNetworks/04D6H/src/truncate.jl:107 [inlined]
 [3] truncate_potts_hamiltonian(potts_h::LabelledGraphs.LabelledGraph{MetaGraphs.MetaDiGraph{Int64, Float64}, Tuple{Int64, Int64, Int64}}, β::Float64, cs::Int64, result_folder::String, inst::String; tol::Float64, iter::Int64)
   @ SpinGlassNetworks ~/.julia/packages/SpinGlassNetworks/04D6H/src/truncate.jl:188
 [4] top-level scope
   @ ~/new-zksi-repo/SpinGlassEngine.jl/test/mwe.jl:32
in expression starting at /home/lpawela/new-zksi-repo/SpinGlassEngine.jl/test/mwe.jl:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants