Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TriggerDagRunOperator #43

Open
y2k-shubham opened this issue Nov 10, 2019 · 1 comment
Open

Support TriggerDagRunOperator #43

y2k-shubham opened this issue Nov 10, 2019 · 1 comment

Comments

@y2k-shubham
Copy link

  • looking into default plugin, it becomes apparent than TriggerDagRunOperator is presently not supported
  • and it it understandable since that would require validation not just within DAG / YAML (which is presently done by networkx library), but across them
    .
  • while ExternalTaskSensor do manage to capture dependencies across DAGs, but they fail to provide the same reactive / eager triggering as TriggerDagRunOperator does
  • Moreover there are cases when a sensor simply cannot replace a triggering-operator without messing up entire schedules of DAGs
    .
  • is there any plan to support them in future?
  • is there a neat approach using which this can be implemented?
@mchalek
Copy link
Member

mchalek commented Nov 21, 2019

hi @y2k-shubham , and thanks for the question. It is a good point about the difficulty of verifying the cross-dag dependencies that are introduced by these operators. At Etsy we have had a longstanding plan to add cross-dag dependency checking to our deployment infrastructure, but it's still not done (and we have had our fair share of errors due to incorrect ExternalTaskSensor specifications as a consequence).

However, given that we do support ExternalTaskSensor, it seems reasonable to me that we could also support TriggerDagRunOperator as well. We would only have to add a configuration for this operator here (and if you would like to do this, we would be happy for the contribution!).

Thanks for the reminder about the need for the cross-dag checking. With the holiday season coming up, we should have more down-time than usual; perhaps opportunities to add this will present themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants