Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRO-1958 - Fix_Guardian_Flow #91

Merged
merged 5 commits into from
Jan 9, 2024
Merged

PRO-1958 - Fix_Guardian_Flow #91

merged 5 commits into from
Jan 9, 2024

Conversation

vignesha22
Copy link
Contributor

Description

  • Added an optional parameter called accountAddress in SDKOptions to specify the contract address they wish to connect and added checks to verify that

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

@linear Linear
Copy link

linear bot commented Dec 27, 2023

PRO-1958 Prime SDK / Contracts: Fix Guardian flow

@github-actions GitHub Actions
Copy link

Yooo! You forgot to bump the version in package.json!

ch4r10t33r
ch4r10t33r approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vignesha22 vignesha22 merged commit 11dee91 into master Jan 9, 2024
5 checks passed
@vignesha22 vignesha22 deleted the PRO-1958-Fix_Guardian_flow branch January 9, 2024 09:20
@arddluma arddluma mentioned this pull request May 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbw33 lbw33 lbw33 approved these changes

@0xSulpiride 0xSulpiride 0xSulpiride approved these changes

@ch4r10t33r ch4r10t33r ch4r10t33r approved these changes

@kaushalrajbacancy kaushalrajbacancy Awaiting requested review from kaushalrajbacancy

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vignesha22 @ch4r10t33r @0xSulpiride @lbw33