Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRO-1991-Manual CallDataLimit Override #88

Merged
merged 6 commits into from
Dec 13, 2023
Merged

PRO-1991-Manual CallDataLimit Override #88

merged 6 commits into from
Dec 13, 2023

Conversation

vignesha22
Copy link
Contributor

Description

  • added ability to override callDataLimit by the user

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

@linear Linear
Copy link

linear bot commented Dec 11, 2023

PRO-1991 callGasLimit needs to be handled automatically

@github-actions GitHub Actions
Copy link

Yooo! You forgot to bump the version in package.json!

@ch4r10t33r ch4r10t33r linked an issue Dec 12, 2023 that may be closed by this pull request
Customize PVG, VG and CGL for a UserOp #62
Closed
ch4r10t33r
ch4r10t33r approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an example program to demonstrate how to use this feature?

ch4r10t33r
ch4r10t33r approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vignesha22 vignesha22 merged commit 1934acb into master Dec 13, 2023
6 checks passed
@vignesha22 vignesha22 deleted the PRO-1991-CallData_Dynamic_Override branch December 13, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbw33 lbw33 lbw33 approved these changes

@ch4r10t33r ch4r10t33r ch4r10t33r approved these changes

@0xSulpiride 0xSulpiride Awaiting requested review from 0xSulpiride

@kaushalrajbacancy kaushalrajbacancy Awaiting requested review from kaushalrajbacancy

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Customize PVG, VG and CGL for a UserOp
3 participants
@vignesha22 @ch4r10t33r @lbw33