Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get gas prices from estimation endpoint #20

Merged
merged 3 commits into from
Aug 17, 2023
Merged

Get gas prices from estimation endpoint #20

merged 3 commits into from
Aug 17, 2023

Conversation

0xSulpiride
Copy link
Member

@0xSulpiride 0xSulpiride commented Aug 17, 2023 •
edited
Loading

Description

  • Getting gas prices from eth_estimateUserOperationGas. Estimating proper gas prices on L2s require knowing the content of the userop, so it's best to put gas prices in this endpoint.
  • Renamed verificationGas to verificationGasLimit, but kept fallback to verificationGas

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

ch4r10t33r
ch4r10t33r approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xSulpiride 0xSulpiride merged commit 34a3255 into master Aug 17, 2023
2 checks passed
@arddluma arddluma deleted the mantle branch November 1, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vignesha22 vignesha22 vignesha22 approved these changes

@ch4r10t33r ch4r10t33r ch4r10t33r approved these changes

@arddluma arddluma Awaiting requested review from arddluma

@lbw33 lbw33 Awaiting requested review from lbw33

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xSulpiride @ch4r10t33r @vignesha22