Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRO-2171-Bundler Error Handling #104

Merged
merged 4 commits into from
Feb 29, 2024
Merged

PRO-2171-Bundler Error Handling #104

merged 4 commits into from
Feb 29, 2024

Conversation

vignesha22
Copy link
Contributor

@vignesha22 vignesha22 commented Feb 28, 2024 •
edited
Loading

Description

  • Added timeout and server error from ethers package
  • Added 429 error from bundler
  • Removed dataModule from exposing to package

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

  • The 429 error handling could not be tested since it cannot be reproduced on my end locally while using sdk

@linear Linear
Copy link

linear bot commented Feb 28, 2024

PRO-2171 Etherspot Prime SDK to handle 429 errors

@github-actions GitHub Actions
Copy link

Yooo! You forgot to bump the version in package.json!

ch4r10t33r
ch4r10t33r approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vignesha22 vignesha22 merged commit aecac62 into master Feb 29, 2024
5 of 6 checks passed
@vignesha22 vignesha22 deleted the PRO-2171-429_Error_Handling branch February 29, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbw33 lbw33 lbw33 approved these changes

@0xSulpiride 0xSulpiride 0xSulpiride approved these changes

@ch4r10t33r ch4r10t33r ch4r10t33r approved these changes

@kaushalrajbacancy kaushalrajbacancy Awaiting requested review from kaushalrajbacancy

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vignesha22 @ch4r10t33r @0xSulpiride @lbw33