Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract address made warm on aborted create call #1019

Open
benSepanski opened this issue Oct 4, 2024 · 1 comment
Open

Contract address made warm on aborted create call #1019

benSepanski opened this issue Oct 4, 2024 · 1 comment
Labels
A-spec Area: specification C-bug Category: this is a bug, deviation, or other problem. E-easy Experience: easy, good for newcomers

Comments

@benSepanski
Copy link

Metadata

  • Hardfork: london

What was wrong?

In the execution python specs, a contract_address is added to the accessed_addresses before the check validating that the sender nonce is small enough, the sender has enough balance, and the call-stack-depth has not overflowed.

This does not appear to match the behavior of CREATE as specified in Appendix H of the yellow paper. go-ethereum also appears to not include the new contract address if the aforementioned checks fail before loading the account at the address of the to-be-created account.

Sources

Authors

@SleepingShell, @benSepanski

@benSepanski benSepanski added A-spec Area: specification C-bug Category: this is a bug, deviation, or other problem. labels Oct 4, 2024
@SamWilsn
Copy link
Collaborator

Thanks for the report! This certainly looks like a bug.

@SamWilsn SamWilsn added the E-easy Experience: easy, good for newcomers label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-spec Area: specification C-bug Category: this is a bug, deviation, or other problem. E-easy Experience: easy, good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants