Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(opdn): Implement from-l2 subcommand with generated fixture #63

Merged
merged 19 commits into from
Aug 16, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Aug 2, 2024

Description

Implements the from-l2 subcommand and fixes up the from-l1 subcommand to derive the valid payload attributes for the given L1 block range or the L1 blocks needed to derive the given L2 block range.

Generated a derivation test fixture with the following command:

cargo run --bin opdn from-l2 --l1-rpc-url <rpc url> --l2-rpc-url <rpc url> --beacon-url <beacon url> --output ./fixtures/derivation/Block123476000.json --start-block 123476000 --end-block 123476001 -vv

@refcell refcell added the A-opdn Area: opdn binary label Aug 2, 2024
@refcell refcell requested review from 0xOsiris and 0xKitsune August 2, 2024 01:50
@refcell refcell self-assigned this Aug 2, 2024
bin/opd8n/src/cmd/from_l1.rs Outdated Show resolved Hide resolved
bin/opd8n/src/cmd/from_l1.rs Outdated Show resolved Hide resolved
bin/opd8n/src/cmd/from_l1.rs Outdated Show resolved Hide resolved
bin/opd8n/src/cmd/from_l1.rs Outdated Show resolved Hide resolved
bin/opd8n/src/cmd/from_l1.rs Outdated Show resolved Hide resolved
bin/opd8n/src/cmd/from_l1.rs Outdated Show resolved Hide resolved
bin/opd8n/src/cmd/from_l2.rs Outdated Show resolved Hide resolved
bin/opd8n/src/cmd/from_l2.rs Outdated Show resolved Hide resolved
bin/opd8n/src/cmd/from_l2.rs Outdated Show resolved Hide resolved
@refcell refcell marked this pull request as draft August 6, 2024 16:29
@refcell
Copy link
Collaborator Author

refcell commented Aug 6, 2024

This is intended to be a draft right now @0xKitsune sorry for the confusion, will let you know when I need reviews :)

@refcell refcell changed the title fix(opd8n): Implement from-l2 subcommand with generated fixture fix(opdn): Implement from-l2 subcommand with generated fixture Aug 16, 2024
@refcell refcell marked this pull request as ready for review August 16, 2024 17:23
@refcell refcell merged commit 75f4fa6 into main Aug 16, 2024
5 checks passed
@refcell refcell deleted the refcell/from-l2 branch August 16, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-opdn Area: opdn binary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants