Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SuperchainERC20Bridge: Support ERC-6909 #399

Open
tynes opened this issue Sep 27, 2024 · 0 comments
Open

SuperchainERC20Bridge: Support ERC-6909 #399

tynes opened this issue Sep 27, 2024 · 0 comments

Comments

@tynes
Copy link
Contributor

tynes commented Sep 27, 2024

The ERC-6909 token standard is a new token standard that was adopted by Uniswap v4. As specified, the SuperchainERC20 bridge will not work well with ERC-6909 tokens. We do want a world where it is possible to bridge these tokens across the superchain natively.

Perhaps an easy solution is to rename the SuperchainERC20Bridge to the SuperchainTokenBridge and then add the following functions:

function sendERC6909(address _tokenAddress, address _to, uint256 _id uint256 _amount, uint256 _chainId) external;
function relayERC6909(address _tokenAddress, address _from, address _to, uint256 id, uint256 _amount) external;

This is not a blocker for going to production but could be a pretty straight forward addition to the contract during a future upgrade.

Renaming the contract to be a more generic token bridge would also make it possible to support ERC721 tokens or really any token standard without needing to introduce new predeploys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant