Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-e2e: Expose context in supersystem op-e2e #13135

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mslipper
Copy link
Collaborator

When any of the setup transactions in TestInterop_EmitLogs fail to be mined, the test hangs until it times out. See here for an example. This PR updates the SuperSystem API to take a context from the test itself to allow for timeouts.

When any of the setup transactions in `TestInterop_EmitLogs` fail to be mined, the test hangs until it times out. See [here](https://app.circleci.com/pipelines/github/ethereum-optimism/optimism/73118/workflows/b48debaa-55bc-4138-a419-a87c236cbc58/jobs/2994655/artifacts) for an example. This PR updates the SuperSystem API to take a context from the test itself to allow for timeouts.
@mslipper mslipper requested review from a team as code owners November 28, 2024 05:32
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.85%. Comparing base (c8f4b3a) to head (c87d5f0).
Report is 8 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13135      +/-   ##
===========================================
- Coverage    44.39%   42.85%   -1.55%     
===========================================
  Files          799      743      -56     
  Lines        71840    67175    -4665     
===========================================
- Hits         31895    28786    -3109     
+ Misses       37352    35965    -1387     
+ Partials      2593     2424     -169     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 63 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant