batdiff test failed with delta 0.18.0

[XYenon]

I think the problem is caused by test/shimexec/less can not deal with less options.

./test.sh --failed --snapshot:show --VERBOSE
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
| Test Suite: batdiff                                                                                                                                                                                            |
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
[FAIL] version              :: Mismatched STDERR snapshot.
 .... Snapshot Difference:
 .... |    1 0a1,4
 .... |    2 > cat: unrecognized option '--RAW-CONTROL-CHARS'
 .... |    3 > Try 'cat --help' for more information.
 .... |    4 > cat: unrecognized option '--RAW-CONTROL-CHARS'
 .... |    5 > Try 'cat --help' for more information.
 .... STDOUT:
 .... |    1 batdiff
 .... |    2 Copyright (C) 2019-2021 eth-p | MIT License
 .... |    3 https://github.com/eth-p/bat-extras
 .... STDERR:
 .... |    1 cat: unrecognized option '--RAW-CONTROL-CHARS'
 .... |    2 Try 'cat --help' for more information.
 .... |    3 cat: unrecognized option '--RAW-CONTROL-CHARS'
 .... |    4 Try 'cat --help' for more information.

Totals:
    PASS: 0 / 1
    FAIL: 1 / 1

[sedlund]

this happens with delta enabled which passes --RAW-CONTROL-CHARS

[XYenon]

It's weird. I found this is triggered by delta --version.

 .... |  202 > + SUPPORTS_BAT_DIFF=true
 .... |  203 > + command -v delta
 .... |  204 > + SUPPORTS_DELTA=true
 .... |  205 > ++ delta --version
 .... |  206 > ++ cut '-d ' -f2
 .... |  207 > cat: unrecognized option '--RAW-CONTROL-CHARS'
 .... |  208 > Try 'cat --help' for more information.
 .... |  209 > + DELTA_VERSION=
 .... |  210 > + version_compare '' -ge 0.12
 .... |  211 > + local version=
 .... |  212 > + local compare=0.12

[XYenon]

It looks like when running delta --version with an empty environment, it will call less.

[sedlund]

they implemented a function to rewrap lines and are putting everything through it including the --version output

dandavison/delta#1440

i don't see the usefulness of test/shimexec/less -- removing it fixes this test.

[n8henrie]

Here's the upstream issue: dandavison/delta#1818

[eth-p]

i don't see the usefulness of test/shimexec/less -- removing it fixes this test.

Back when it was originally written, it had two purposes:

1. To make sure that calling less didn't freeze the tests waiting for less, which itself was waiting for user input.
2. For mocking the less version, to test different behaviors based around that.

Either way, easy fix.