Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misleading error message: foo.library not found #194

Closed
ManasJayanth opened this issue Dec 1, 2020 · 3 comments · Fixed by #199
Closed

Misleading error message: foo.library not found #194

ManasJayanth opened this issue Dec 1, 2020 · 3 comments · Fixed by #199

Comments

@ManasJayanth
Copy link
Member 

        "Library = require('foo/library')"

When the library folder was renamed to src/lib, Dune threw "foo.library not found.

This can be confusing. pesy should have pointed to the require() statement and pointed out the incorrect (because outdated) library path.
@melwyn95
Copy link
Collaborator

melwyn95 commented Dec 2, 2020

should we add validation while reading the paths in require? (check if the path exists)

@ManasJayanth
Copy link
Member Author

Yes, via findlib.

@ManasJayanth
Copy link
Member Author

Related TODO - #49

@melwyn95 melwyn95 mentioned this issue Jan 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix misleading error message when local library not found melwyn95/pesy
2 participants
@ManasJayanth @melwyn95