feat(es_extended/shared/main): restore backwards compat #1528
+6
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR brings back the
esx:getSharedObject
event, a key feature that was removed in ESX 1.9 after being deprecated in 1.8.5. The removal of this event caused compatibility issues with many legacy scripts, leading to frustration in the community.The proposed solution restores the event and includes a warning message encouraging developers to migrate to newer methods. This approach keeps backward compatibility for existing resources while gently guiding the community toward best practices.
Justification
No Good Reason for Removal
esx:getSharedObject
event didn't come with a clear, justified reason. It was widely used across the ESX ecosystem, and removing it created unnecessary issues. The lack of a technical need for this change meant that many developers and server owners were left with broken setups for no good reason.Preserving Backward Compatibility
Supporting Legacy and Abandoned Scripts
esx:getSharedObject
event. These scripts can't be easily updated to the new import system, and removing the event effectively rendered them useless.Clear Communication for a Smooth Transition
Conclusion
Bringing back the
esx:getSharedObject
event is an important step in rebuilding trust with the community and ensuring compatibility with older scripts. While we continue to encourage the adoption of better practices, it's essential that ESX evolves in a way that doesn’t break existing functionality. By doing this, we show that we value developer confidence, backward compatibility, and a smooth transition for all users of the ESX framework.PR Checklist