fix(cron): validate arguments in RunAt and improve timestamp handling #1498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kenshiin13
requested changes
Nov 23, 2024
Kenshiin13
requested changes
Nov 24, 2024
| @@ -12,6 +12,11 @@ local lastTimestamp = false | |||
| ---@param m number | |||
| ---@param cb function|table | |||
| function RunAt(h, m, cb) | |||
| if type(h) ~= "number" or type(m) ~= "number" or (type(cb) ~= "function" and type(cb) ~= "table") then | |||
There was a problem hiding this comment.
Type validation is already being handled in the cron:runAt event. Please remove the redundant code.
Kenshiin13
requested changes
Nov 24, 2024
| local currentDay = os.date("*t", timestamp).day | ||
| local currentMonth = os.date("*t", timestamp).month | ||
| local currentYear = os.date("*t", timestamp).year | ||
|
|
There was a problem hiding this comment.
Refactor to call os.date("*t", timestamp) once, store the result in a local table, and extract the required fields (day, month, year) from that table. This improves efficiency by avoiding repeated parsing and enhances code readability and maintainability.
|
Closing this due to inactivity. The relevant suggested changes are already implemented on the dev branch anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.